WHDLoad MantisBT - Elvira
View Issue Details
0006680Elvira[All Projects] Generalpublic2025-01-18 19:152025-02-27 00:13
ReporterTorti the Smurf 
Assigned ToWepl 
PrioritynormalSeveritytweakReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
MachineA1200
CPU68020
CPUSpeed50
ChipSetAGA
GFXCardNone
ChipMem2 MB
FastMem32 MB
WorkbenchOS 3.9
KickROM40 - Kick 3.1
KickSoftNone
WHDLoad19.1
imported
Summary0006680: Umlauts in the German version are broken/glitched
DescriptionThe german whdload version has this text glitch since 1.0.

You see, (in the pictures that i attached)
that the german "umlaut" ü is (randomly) glitched in some scenes, or missing.

The same text is not broken when running from the same disks. (original)

PLEASE fix this Amiga Classic (T_T)
Steps To ReproduceJust load my savestate (RESTORE > the name is 1)
then click on the meat and you see the ü is glitched.

If you press on Save and type 1 to overwrite the gamesave
the Ü is completly missing.

I am not sure if only the "Ü´s" are affected. (did not finsih it ... yet)

Not sure if the broken text also affect or corrups other thing in memory.

Hopefully this gets fixed because Elvira is such a Amiga Classic and such a PAIN
to run on anything higher than a 1.2/1.3 Rom.

Greetings and thanks,
Torti
TagsNo tags attached.
Attached Filesjpg MissingLetter-Ü.jpg (170,821) 2025-01-18 19:15
https://whdload.eu/mantis/file_download.php?file_id=1876&type=bug
jpg

jpg Example-Meat-Random1.jpg (186,301) 2025-01-18 19:15
https://whdload.eu/mantis/file_download.php?file_id=1877&type=bug
jpg

jpg Example-Meat-Random2.jpg (186,404) 2025-01-18 19:15
https://whdload.eu/mantis/file_download.php?file_id=1878&type=bug
jpg

? 1 (21,780) 2025-01-18 19:16
https://whdload.eu/mantis/file_download.php?file_id=1879&type=bug
jpg Without-WHDLOAD.jpg (174,037) 2025-01-25 20:41
https://whdload.eu/mantis/file_download.php?file_id=1881&type=bug
jpg

jpg Without-WHDLOAD-2.jpg (174,037) 2025-01-25 20:42
https://whdload.eu/mantis/file_download.php?file_id=1882&type=bug
jpg

jpg Without-WHDLOAD2.jpg (160,291) 2025-01-25 20:44
https://whdload.eu/mantis/file_download.php?file_id=1883&type=bug
jpg

? ElviraDePatchFinal.lha (106,849) 2025-02-02 00:57
https://whdload.eu/mantis/file_download.php?file_id=1888&type=bug
? ElviraDePatchFinal-2.lha (106,850) 2025-02-02 23:07
https://whdload.eu/mantis/file_download.php?file_id=1889&type=bug
jpg example1.jpg (86,358) 2025-02-25 11:09
https://whdload.eu/mantis/file_download.php?file_id=1895&type=bug
jpg

jpg example2.jpg (75,839) 2025-02-25 11:09
https://whdload.eu/mantis/file_download.php?file_id=1896&type=bug
jpg

? Elvira.Slave (5,312) 2025-02-26 21:17
https://whdload.eu/mantis/file_download.php?file_id=1898&type=bug

Notes
(0014346)
Torti the Smurf   
2025-01-23 20:00   
\(^-^)/ Thank you Wepl \(^-^)/
(0014347)
Wepl   
2025-01-24 21:36   
And there is no problem when running without WHDLoad?
(0014348)
Torti the Smurf   
2025-01-25 20:39   
None.

I attach two Photos of the same Location with the exact same Files,
but without the WHDLoad Slave.

Maybe you could try the 1.2 kickrom ? This Game is a bitch ... literally ;)
(0014349)
Torti the Smurf   
2025-01-25 20:49   
Had a little issue with the upload of the screenshots; 3 photos where uploaded.
(0014353)
Torti the Smurf   
2025-01-26 23:42   
Sorry Wepl, the same files from the floppys where ok with ScummVM
but not when running in WinUAE or the Mist/er.

Still Odd, nobody ever mentioned this. No german review that i could find.
Why is that; some font table mixup ?
Should you close this ?
idk anymore..sorry Wepl
(0014357)
Torti the Smurf   
2025-01-27 15:06   
Found the issue !!!; and its NOT the fault of the WHDLoad Slave !!!

(i did not remember to having this issue back then)

The Issue is within the File called "gameamiga" !

If you look at that file in HEX and seach for the entry "Stück fleisch"
you will see a weird symbol.
The Game dont "knows" Ü´s and such "umlauts" and works with % a
nd other symbols instead.

Right at the beginning of Elvira; when the guard captures the "player"
there is a German line...
"... in das Büro des Wachkäptens"

So the Ü Font is there! but its a % in HEX in that scene but not for the "Fleisch scene" ;)
 
Then i tried to edit that into the "Stück Fleisch" ; .. did not work... hmm

But a "u" or any other Letter works... very odd. ill look at that some more.

This can be closed, i gues; Sorry Wepl but my memories have failed me :(
(0014358)
Torti the Smurf   
2025-01-27 15:25   
Well look at that :)
Get this, dear Mr. Wepl.

The line "Stück Fleisch" has to be written like this "St%Ck Fleisch"

% = ü

yes, but the C has to be in CAPS otherwise it wont find the correct Font.

What a weird bug :) .. Hmm, think i edit that with the HexEditor.
Dont know how many of those font glitches are in there ...

Greetings and thanks
Torti
(0014359)
Wepl   
2025-01-27 20:23   
I did already see this. The problem is probably that some strings are printed using a printf variant function which uses % as a formatting char. Will see if this can be patched somehow.
The save game 'Überschreiben' is contained in the runit exe and can probably fixed directly.
(0014360)
Torti the Smurf   
2025-01-27 22:39   
Yup.
I manually patch (edit) the Mainfile (gameamiga) while playing though it.
(half way there)

There are tons of those glitches in the German version.
Also, some lines are false or not complete.

This needs more then a "replace this with that".

I go through this, line by line. Its super tedious :)

The missing Ü in "überschreiben" was the first thing i fxed ;)

This will take a while, but ill do it !

Greetings and sorry again for all the extra work that i might have caused. :(

i would have a feature request if you wont mind: Movement with the Arrow Keys.
That would be so helpful.

Thank you Wepl.
(0014374)
Torti the Smurf   
2025-02-02 00:57   
added the reworked files or the German version;
just in case you have any use for it.

finished it two times from start to finish.

greetz
(0014375)
Torti the Smurf   
2025-02-02 01:11   
edit: of/from the German version; damn typos!
(why is there no edit feature on mantis?;)

time to take a nap ...

(=____=)
(0014376)
Torti the Smurf   
2025-02-02 23:07   
Ohh for f. sake !;i found one more garbled text on my third and last playthrough!

fixed. I think i can finsih that game pretty much blindfolded now ;)

greetz
(0014386)
Wepl   
2025-02-12 01:43   
Can you test attached Slave?
I have fixed the ü umlauts and added your patches to gameamiga into the Slave.
Please test with the original gameamiga!
source: https://github.com/wepl/winstalls
(0014387)
Torti the Smurf   
2025-02-13 13:37   
Its not only the Ü´s :)

Did a quick test tho.
(go 1 step forwart,turn right & look at the painting of the Castle. Text fixed)

But in the "Elvira is rescuing the player" sequence,
a whole text passage is missing; so i cant approve that ;)
(0014388)
Torti the Smurf   
2025-02-13 13:42   
ähh..i meant "forward, NOT forwart XD ; those typos are so embarrassing.
(0014389)
Torti the Smurf   
2025-02-13 14:23   
Just a thought ... wouldn´t it be simpler to just add the patched file
and make that a choosable option for the installprocess itself ?
(0014391)
Torti the Smurf   
2025-02-14 15:30   
Hmmm, a lot of Item despriptions has been trashed by the new slave.
(just from a short test)

This is one of those cases, where you fix one thing
and on the other end, something else breaks.

I was always a "if it works, dont fix it" guy.
When the endresult on the Screen is the same,
why taking the risk of probably introducing new bugs. (i never undersdood)

There are some WHDLoad Installs that come with additional files,
so this would not be the first time; just give the user the option
to choose the patched German version on install.

With that, lots of additional testing, time & headegg´s could be avoided.
Just saying ;)

Hmm, there are slaves that weren't updated for about 20 years,
like the FEARS AGA slave.
The forced Trainer is a problem on some configs and CACHE is forced off on an AGA C2P Game, yet, nothing happends :)

anyway, getting of track here (sorry)

If you dont mind; i would just update the install, really.
That has been tested and prooven to be working just fine.

(finished the game 3 times from start to finish with the German patched files)

https://whdload.de/mantis/file_download.php?file_id=1889&type=bug

Greetings,
Torti

https://whdload.de/mantis/file_download.php?file_id=1889&type=bug
(0014392)
Torti the Smurf   
2025-02-14 15:33   
Aehm.. those are just the links for the Final, Final Patch.
Dont know why it doubled ... its here anyway. called:

ElviraDePatchFinal-2

(^_^)
(0014412)
Wepl   
2025-02-24 22:41   
Da war ein Assemblerfehler, weswegen die Texte abgeschnitten waren.
Das ist jetzt gefixt.
Das 'gameamiga' lege ich nicht bei wegen Copyright und Bloat.
Ich habe nur einige Text von dir übernommen. Andere gehen mir zu weit, bzw. kann ich nicht beurteilen ob das passt. Du kannst hier prüfen was ich übernommen habe: https://github.com/wepl/winstalls/commit/dcc6a3eb096e8de2243aea9c1b2eeda44cc075ab
Schön wenn du es nochmal testen magst. Dann würde ich es releasen.
Falls du andere Änderungen hast gerne als PR zum Slave Source.
(0014414)
Torti the Smurf   
2025-02-25 11:11   
The amount of ingredients are not shown. Instead it says "üd"

Elvira calling her rescuer "Bastard" (creep in the engl. version) is really weird.

I´ll stick to my Translation ;)
(0014420)
Wepl   
2025-02-26 21:19   
Yes, that was my mistake, %d was no longer expanded.
Should be fixed now.
I also fixed your upper case changes after ü (e.g. 'StüCk Fleisch').
I think it should be ready now.
(0014421)
Torti the Smurf   
2025-02-26 22:39   
it is.

Great Job Wepl !

   \(^-^)/
(0014422)
Wepl   
2025-02-26 22:57   
Thanks for testing!
Released now.
(0014423)
Torti the Smurf   
2025-02-27 00:13   
Nice! Thanks also to Psygore (◠‿◠) ... Hey there psy! ;)

What ya think; any chance of revisiting the Fears AGA slave after 20 years?
(CACHE wont work; forced trainer can lead to timing issues on some configs)

/\_/\
(='_' )
(, (") (")
---------------Greez & Thanks Guys!

Issue History
2025-01-18 19:15Torti the SmurfNew Issue
2025-01-18 19:15Torti the SmurfFile Added: MissingLetter-Ü.jpg
2025-01-18 19:15Torti the SmurfFile Added: Example-Meat-Random1.jpg
2025-01-18 19:15Torti the SmurfFile Added: Example-Meat-Random2.jpg
2025-01-18 19:16Torti the SmurfFile Added: 1
2025-01-23 15:19WeplAssigned To => Wepl
2025-01-23 15:19WeplStatusnew => assigned
2025-01-23 20:00Torti the SmurfNote Added: 0014346
2025-01-24 21:36WeplNote Added: 0014347
2025-01-25 20:39Torti the SmurfNote Added: 0014348
2025-01-25 20:41Torti the SmurfFile Added: Without-WHDLOAD.jpg
2025-01-25 20:42Torti the SmurfFile Added: Without-WHDLOAD-2.jpg
2025-01-25 20:44Torti the SmurfFile Added: Without-WHDLOAD2.jpg
2025-01-25 20:49Torti the SmurfNote Added: 0014349
2025-01-26 23:42Torti the SmurfNote Added: 0014353
2025-01-27 15:06Torti the SmurfNote Added: 0014357
2025-01-27 15:25Torti the SmurfNote Added: 0014358
2025-01-27 20:23WeplNote Added: 0014359
2025-01-27 22:39Torti the SmurfNote Added: 0014360
2025-02-02 00:57Torti the SmurfFile Added: ElviraDePatchFinal.lha
2025-02-02 00:57Torti the SmurfNote Added: 0014374
2025-02-02 01:11Torti the SmurfNote Added: 0014375
2025-02-02 23:07Torti the SmurfFile Added: ElviraDePatchFinal-2.lha
2025-02-02 23:07Torti the SmurfNote Added: 0014376
2025-02-12 01:42WeplFile Added: Elvira.Slave
2025-02-12 01:43WeplNote Added: 0014386
2025-02-13 13:37Torti the SmurfNote Added: 0014387
2025-02-13 13:42Torti the SmurfNote Added: 0014388
2025-02-13 14:23Torti the SmurfNote Added: 0014389
2025-02-14 15:30Torti the SmurfNote Added: 0014391
2025-02-14 15:33Torti the SmurfNote Added: 0014392
2025-02-24 22:33WeplFile Deleted: Elvira.Slave
2025-02-24 22:33WeplFile Added: Elvira.Slave
2025-02-24 22:41WeplNote Added: 0014412
2025-02-25 11:09Torti the SmurfFile Added: example1.jpg
2025-02-25 11:09Torti the SmurfFile Added: example2.jpg
2025-02-25 11:11Torti the SmurfNote Added: 0014414
2025-02-26 21:17WeplFile Deleted: Elvira.Slave
2025-02-26 21:17WeplFile Added: Elvira.Slave
2025-02-26 21:19WeplNote Added: 0014420
2025-02-26 22:39Torti the SmurfNote Added: 0014421
2025-02-26 22:57WeplStatusassigned => resolved
2025-02-26 22:57WeplResolutionopen => fixed
2025-02-26 22:57WeplNote Added: 0014422
2025-02-27 00:13Torti the SmurfNote Added: 0014423